-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set buildmode to pie and drop pie and debuginfo patches for kubernetes #1103
Conversation
b743dd7
to
e1315ea
Compare
Can you verify using checksec that the You can extract the RPMs in
(This needs to be integrated as check during package builds, but hasn't been automated yet.) |
It says PIE enabled for all 3 versions of kubernetes. Please find the output below.
|
Can you update the title, description, and testing done? LGTM otherwise. |
23f3f95
to
622966c
Compare
Issue number:
#1102
Description of changes:
Removed the patches 0002-do-not-omit-debug-info.patch and 0003-enable-PIE-for-platform-binaries.patch and exported GOLDFLAGS as "-buildmode=pie" in the spec files of the different kubernetes versions. Also renumbered the bottlerocket patches that were created for kubernetes.
Testing done:
1>Built bottlerocket successfully.
2>Verified using checksec that the kubelet binaries are all still built as PIE.
3>Made sure that this goldflag along with the SOURCE_DATE_EPOCH flag can build reproducible binaries for upstream kubernetes.
4>Created an AMI and ran busybox pod with it.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.