update to systemd 246 and dbus-broker 24 #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
reviewed
Oct 21, 2020
Drop the libcap dependency, since it's only used if we enable audit support, and the audit support actually requires libcap-ng instead. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
In v246, systemd added an sd_notify_barrier function to avoid a race when the notification is sent by a different process than the one it spawned. The barrier works by sharing a file descriptor between the process and systemd. That doesn't apply to our use case, and the shared file descriptor complicates the SELinux policy, since systemd would need to write to a file owned by apiserver. Work around this by passing the new `--no-block` argument to the `systemd-notify` command. Signed-off-by: Ben Cressey <bcressey@amazon.com>
bcressey
force-pushed
the
systemd-update
branch
from
db37921 to
26c1dd0
Compare
tjkirch
approved these changes
Oct 22, 2020
webern
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1015, fixes #1175
Description of changes:
Update systemd and dbus-broker to the latest release.
Work around a behavior change in systemd-notify that caused an SELinux denial when starting apiserver.
Testing done:
Launched x86_64 and aarch64 nodes. Confirmed that the nodes joined the cluster, ran pods OK.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.