Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: build migrations in parallel #1192

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Oct 30, 2020

Description of changes:

This took os build time from 388 seconds to 218 seconds on my machine, almost 3 minutes saved.

Testing done:

The built RPM still has all of the migrations, same as before the change:

./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v0.3.2_admin-container-v0-5-0
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v0.4.1_add-version-lock-ignore-waves
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v0.4.1_pivot-repo-2020-07-07
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v0.5.0_add-cluster-domain
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v0.5.0_admin-container-v0-5-2
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v0.5.0_control-container-v0-4-1
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.0.0_ecr-helper-admin
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.0.0_ecr-helper-control
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.0.2_add-enable-spot-instance-draining
./aarch64-bottlerocket-linux-gnu/sys-root/usr/share/migrations/migrate_v1.0.3_add-sysctl

This is the command run during the build:

#17 0.167 + /usr/bin/cargo build --offline --locked --verbose --target aarch64-bottlerocket-linux-musl --release --manifest-path /home/builder/rpmbuild/BUILD/sources/Cargo.toml -p apiclient -p migrate-admin-container-v0-5-0 -p pivot-repo-2020-07-07 -p add-version-lock-ignore-waves -p add-cluster-domain -p migrate-admin-container-v0-5-2 -p migrate-control-container-v0-4-1 -p ecr-helper-control -p ecr-helper-admin -p add-enable-spot-instance-draining -p add-sysctl

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@tjkirch tjkirch requested a review from bcressey October 30, 2020 23:29
Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tjkirch tjkirch merged commit eed27a1 into bottlerocket-os:develop Oct 31, 2020
@tjkirch tjkirch deleted the migration-build-parallel branch October 31, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants