Fix build.yml to ignore changes that include only .md files #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a lot of CI to run for a PR to a markdown file. This PR should just say "hey, if it's all md files, just, y'know, don't do that." I can't think of any cases in which we'd want .md file changes to kick off CI runs, but if you can, feel free to reject this PR. Also, here's to the GitHub built-in editor for making sure the yaml is right.
tjkirch
approved these changes
Jan 11, 2021
|
I missed the obvious. See @etungsten's response. |
|
It looks like it should work, based on the documentation. However CI ran for this PR which means it did not work as desired. |
|
The CI ran for this PR because the change is against a |
samuelkarp
approved these changes
Jan 11, 2021
🎓 |
webern
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a lot of CI to run for a PR to a markdown file. This PR should allow build.yml to say "hey, if it's all md files, just, y'know, don't do all that stuff."
I can't think of any cases in which we'd want .md file changes to kick off CI runs, but if you can, feel free to reject this PR.
Also, cheers to the GitHub built-in editor for making sure the yaml is right.
Issue number:
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.