build-kmod-kit: use explicit paths #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, this step used /home/builder for input and output artifacts and /tmp for preparing the contents of the final output tarball. It assumed that /home/builder was readable and writable by the current user, though in the image it's owned by builder:builder. This can cause the following: ``` [cargo-make] INFO - Running Task: build-kmod-kit find: './rpms': Permission denied find: Failed to restore initial working directory: /home/builder: Permission denied cpio: premature end of archive [cargo-make] ERROR - Error while executing command, exit code: 2 ``` This change makes the path usage more explicit by no longer relying on /home/builder and avoiding use of the current working directory. Working artifacts and output artifacts are put in separate directory trees under /tmp.
samuelkarp
approved these changes
Jan 21, 2021
bcressey
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, this step used /home/builder for input and output artifacts and /tmp
for preparing the contents of the final output tarball. It assumed that
/home/builder was readable and writable by the current user, though in the
image it's owned by builder:builder. This can cause the following:
This change makes the path usage more explicit by no longer relying on
/home/builder and avoiding use of the current working directory. Working
artifacts and output artifacts are put in separate directory trees under /tmp.
Testing done:
Build now succeeds:
Kit artifact still looks good:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.