Add a systemd mount unit for CD-ROM devices #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
approved these changes
Jan 22, 2021
tianon
reviewed
Jan 22, 2021
jahkeup
approved these changes
Jan 22, 2021
bcressey
reviewed
Jan 23, 2021
bcressey
reviewed
Jan 23, 2021
zmrow
commented
Jan 25, 2021
|
Addressed all comments! |
jahkeup
approved these changes
Jan 25, 2021
This change adds a mount unit that will mount a CD-ROM device located at /dev/cdrom to /media/cdrom if that device exists. systemd includes a udev rule to symlink a suspected CD-ROM device to /dev/cdrom. The primary use of said device to supply user data to a bottlerocket host.
|
Per offline conversation, removed |
bcressey
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #1288
Description of changes:
This change adds a mount unit that will mount a CD-ROM device located at
/dev/cdromto/media/cdromif that device exists. systemd includes audev rule to symlink the first suspected CD-ROM device to
/dev/cdrom. Theprimary use of said device to supply user data to a Bottlerocket host.
Testing done:
early-boot-configproperly exited gracefully after no user data was found at the cd-rom location.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.