updog: respect proxy settings #1324
Conversation
sources/updater/updog/src/main.rs
Outdated
| _ => return Ok(()), | ||
| }; | ||
|
|
||
| // TODO - remove this if reqwest adds support for proxy addresses with no scheme |
There was a problem hiding this comment.
I think you opened a GitHub issue for this in reqwest's repository, want to link it here?
There was a problem hiding this comment.
Linked to our own #1332 since it's a little bit wrapped up in a dependency knot.
Link to a tracking issue for workaround removal. |
Rebase. |
packages/os/updog-toml
Outdated
| {{#if settings.network.https-proxy}} | ||
| https_proxy="{{settings.network.https-proxy}}" | ||
| {{/if}} | ||
| {{#if settings.network.no-proxy}} | ||
| no_proxy=[{{join_array ", " settings.network.no-proxy}}] | ||
| {{/if}} |
There was a problem hiding this comment.
nit: can suppress the additional newlines this will generate:
| {{#if settings.network.https-proxy}} | |
| https_proxy="{{settings.network.https-proxy}}" | |
| {{/if}} | |
| {{#if settings.network.no-proxy}} | |
| no_proxy=[{{join_array ", " settings.network.no-proxy}}] | |
| {{/if}} | |
| {{~#if settings.network.https-proxy}} | |
| https_proxy="{{settings.network.https-proxy}}" | |
| {{~/if}} | |
| {{~#if settings.network.no-proxy}} | |
| no_proxy=[{{join_array ", " settings.network.no-proxy}}] | |
| {{~/if}} |
rebase |
Adds https-proxy and no-proxy settings to updog's config file. These are used to set HTTPS_PROXY and NO_PROXY environment variables for the process at the beginning of the program which which ensures that they are used by the underlying HTTP client.
Cleaner config file with Ben's template syntax suggestion. |
Issue number:
#1300
Description of changes:
Adds https-proxy and no-proxy settings to updog's config file. These are
used to set HTTPS_PROXY and NO_PROXY environment variables for the
process at the beginning of the program which ensures that they
are used by the underlying HTTP client.
Testing done:
Upgrade Downgrade
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.