Allow overriding the "pretty" name of the OS inside the image #1330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1314 - thanks @diranged!
Description of changes:
Similar to #1312, this passes another field through for user customization - this time the "pretty name" that shows up in os-release, which in turn is used by k8s and other tools.
The second commit reorganizes buildsys's builder module to use argument vectors instead of strings, so we can handle arbitrary characters, rather than using "|" as a marker (and subsequently making it unavailable to names).
Testing done:
Specifying a pretty name works:
Default is still OK:
Retested with the second (refactor) commit and found that buildsys still produced the artifacts in the same way, and the resulting AMIs were still happy and healthy. Here's one with a weird name:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.