-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: update to 19.03.15 #1333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update docker-init's version to match as well? (It's just intended to match, it doesn't reflect upstream.)
You mean in docker-init.spec? I don't know what it means. Should we? |
We should, yeah. We don't version that package to match upstream tini (which is 0.19.0), we have it match our Docker packaging, since we sort of "repackage" it as docker-init. |
I see that version string in |
Ah, good catch, I always forget about proxy. If you look in the spec file there, we also have to check that the libnetwork commit hasn't changed, but it looks like we're still good there, so yeah, just updating the version number to match Docker. |
Bump version in docker-init and docker-proxy |
Issue number:
Closes #1305
Description of changes:
Update docker to 19.03.15
Testing done:
Ran an ECS task on x86 and on arm, it worked!
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.