Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults, migrations: admin container version bump to v0.6.0 #1347

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

jpculp
Copy link
Member

@jpculp jpculp commented Feb 23, 2021

Issue number:

N/A

Description of changes:

Migrates default version of admin container from v0.5.2 to v0.6.0

Testing done:

@etungsten
Tested the migrations via upgrade/downgrade on a Bottlerocket host and it works as expected (source template gets replaced, admin container source points to v0.6.0)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jpculp jpculp requested review from tjkirch, zmrow and webern February 23, 2021 20:25
Set default admin container version to v0.6.0
@jpculp jpculp force-pushed the admin-container-migrate-v0.6.0 branch from 9ca000f to 7dfc6d4 Compare February 24, 2021 23:46
@jpculp
Copy link
Member Author

jpculp commented Feb 24, 2021

  • Rebased to latest upstream
  • Fixed container prefixes in migration

@jpculp jpculp marked this pull request as ready for review February 24, 2021 23:49
Migrates default version of admin container from v0.5.2 to v0.6.0
@jpculp jpculp force-pushed the admin-container-migrate-v0.6.0 branch from 7dfc6d4 to fb450cc Compare February 25, 2021 03:33
@jpculp
Copy link
Member Author

jpculp commented Feb 25, 2021

  • Fixed container templates in migration (for real)

@jpculp jpculp requested a review from tjkirch February 25, 2021 03:34
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, once the testing is complete.

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💸

Once testing is complete I'm happy with this.

Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the migrations via upgrade/downgrade on a Bottlerocket host and it works as expected (source template gets replaced, admin container source points to v0.6.0)

Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jpculp jpculp merged commit 4c070eb into bottlerocket-os:develop Feb 25, 2021
@jpculp jpculp deleted the admin-container-migrate-v0.6.0 branch February 26, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants