-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shibaken: return empty key list if IMDS returns 404 #1358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please also add a commit that adds this PR ID/link to the changelog entry for the shibaken set of changes?
I have tested these changes. Before these changes an instance without a key failed to boot. With these changes the instance came up and I ran an ECS task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon most variant arches passing CI. :)
63d5abe
to
455fd2a
Compare
|
In the case where there are no keys available in IMDS, shibaken will create an empty public key list instead of returning an error.
455fd2a
to
e7fbd4d
Compare
|
Issue number:
N/A
Description of changes:
In the case where there are no keys available in IMDS, shibaken will create an empty public key list instead of returning an error.
This addresses a rare scenario where a user launches an instance of Bottlerocket without attaching a key to the EC2 instance. Rather than returning an empty string, the IMDS request for available keys returns a 404. The 404 status causes shibaken to return an error and prevents Bottlerocket from booting.
Testing done:
Set
IMDS_PUBLIC_KEY_BASE_URI
to an invalid URI and cargo ranshibaken
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.