QUICKSTART: prefer resolve:ssm: parameters for simplicity #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "simple option" was originally the note at the end of this section about using the SSM web console. That link changed, but we also discovered that you have to have created a parameter in that region yourself to be able to use the search quicklink. Requiring that would be awkward, so we remove the link. A simpler option for most people is to use the resolve:ssm: prefix to have EC2 dynamically fetch the latest AMI ID from SSM. This updates the wording to prefer that option, creating a new subsection for manually fetching parameters.
gregdek
approved these changes
Mar 3, 2021
samuelkarp
reviewed
Mar 3, 2021
This was put in for completeness, but goes against the purpose of the quickstart guides, which is to get an interested user launching Bottlerocket quickly, and it's awkward to word such a different purpose here. The BUILDING guide is linked from README right after the links to the quickstart guides, for users that have more advanced needs and need to build their own images.
samuelkarp
approved these changes
Mar 4, 2021
webern
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also didn't think there was a reason to have the wording at the top of the ECS quickstart be different from the k8s one, so I made those match as part of the change.
Testing done:
Ran launches with the given
resolve:ssm:prefixes to confirm they're correct. Ran the updated aws-cli commands to ensure they still gave our results.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.