Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models README: fix broken links for symlink'd files #1444

Merged

Conversation

etungsten
Copy link
Contributor

Issue number:
N/A

Description of changes:

Author: Erikson Tung <etung@amazon.com>
Date:   Fri Apr 2 15:41:58 2021 -0700

    models README: fix broken links for symlink'd files
    
    The links for all the aws-k8s-* variants don't work when accessing them
    on github since we can't follow symlinks in that context.
    
    Since all aws-k8s-* variants currently use the same model and default
    values, let's link directly to the source of all the symlinks.

Testing done:

Links are no longer broken when accessing them on github.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

The links for all the aws-k8s-* variants don't work when accessing them
on github since we can't follow symlinks in that context.

Since all aws-k8s-* variants currently use the same model and default
values, let's link directly to the source of all the symlinks.
@etungsten etungsten requested review from tjkirch and gregdek April 2, 2021 22:53
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔬

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the equivalent in #1437 :)

I hope GitHub makes links possible in the future...

@etungsten etungsten merged commit 91ea851 into bottlerocket-os:develop Apr 5, 2021
@etungsten etungsten deleted the models-readme-link-fix branch April 5, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants