Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-containers: chmod persistent storage directory after creation #1463

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Apr 7, 2021

Description of changes:

Tighten the permissions on the host-container-specific persistent storage directories, to reduce the chances that some other mistake could allow access to registration tokens, etc.

Testing done:

Before:

bash-5.0# ls -l /local/host-containers/
total 8
drwxr-xr-x. 3 root root 4096 Apr  5 23:19 admin
drwxrwxrwt. 2 root root 4096 Apr  5 23:18 control

After:

bash-5.0# ls -l /local/host-containers/
total 8
drwx------. 3 root root 4096 Apr  7 19:36 admin
drwx------. 2 root root 4096 Apr  7 19:36 control

Admin and control containers both still work as expected.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@tjkirch tjkirch requested review from bcressey and jpculp April 7, 2021 20:24
@tjkirch tjkirch added this to the 1.0.8 milestone Apr 7, 2021
Copy link
Member

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Do we want to set the permissions explicitly for user-data as well?

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦞

@tjkirch tjkirch merged commit 436bc67 into bottlerocket-os:develop Apr 7, 2021
@tjkirch tjkirch deleted the host-container-perms branch April 7, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants