update SDK to 0.20.0 #1497
Merged
update SDK to 0.20.0 #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
reviewed
Apr 19, 2021
|
(rebase with no changes) |
webern
reviewed
Apr 20, 2021
tjkirch
reviewed
Apr 21, 2021
| @@ -157,6 +157,7 @@ done | |||
| [tasks.fetch] | |||
| dependencies = [ | |||
| "fetch-sdk", | |||
| "fetch-toolchain", | |||
There was a problem hiding this comment.
I wonder if we're losing useful granularity with this "fetch" task. There are a number of places we have granular fetch-* dependencies, and a few places that just fetch everything, and I think most of them wouldn't need the toolchain, for example.
If it were more granular, I think the user wouldn't need to change their Docker config unless they were building a kmod kit...
There was a problem hiding this comment.
In the kmod kit rework for supporting multiple kernels, I ended up needing the toolchain for variant builds since that's the point in time where we have the information we need about the kernel we're installing in the image.
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Go 1.16 defaults to GO111MODULE="on", but this breaks builds if the project has not adopted modules yet. See upstream discussion: golang/go#41330 Signed-off-by: Ben Cressey <bcressey@amazon.com>
Support for bare words in expressions was removed in rpm 4.16. Signed-off-by: Ben Cressey <bcressey@amazon.com>
This build produces a mix of host tools and target modules, and new versions of RPM build scripts from Fedora will attempt to strip both. When cross-compiling, there's no single version of `strip` that can do this successfully, and this now fails when building on an x86_64 host for the aarch64 target. We only use the tools and modules to generate the bootloader images, and they are not shipped anywhere. Hence we do not really care about extracting debuginfo and can just leave the files unstripped. Signed-off-by: Ben Cressey <bcressey@amazon.com>
The SDK and toolchain are now vended as containers, so we pull them from ECR rather than from S3. The SDK includes `cargo deny`, so we use its copy and no longer need it to be installed on the build host. Signed-off-by: Ben Cressey <bcressey@amazon.com>
|
(rebase with no changes) |
webern
approved these changes
Apr 26, 2021
tjkirch
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1455, fixes #582
Description of changes:
Update to the latest SDK, with new versions of GCC, Rust, and Go.
Retrieve the SDK and toolchain as containers from ECR, rather than archives from S3.
Fix minor issues related to the new Fedora base image and the new version of Go.
Use
cargo denyfrom the SDK.Testing done:
Verified that local builds of
aws-devworked under KVM for both arches.For
aws-ecr-1andaws-k8s-1.19, confirmed that:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.