-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a vmware-k8s-1.20 variant #1511
Conversation
^ Fix the Cargo.lock... oops :) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰
sources/models/src/vmware-k8s-1.19/defaults.d/50-vmware-k8s.toml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on the config refactors for #1511 (comment) and #1511 (comment).
^ Addresses @tjkirch 's comments |
^ rebase on |
^ Adds the kernel to |
^ Wow, sorry. I thought I was being funny by saying my PR would resolve a comment in this PR, but it closed the whole PR. Reopened! |
sources/models/src/vmware-k8s-1.20/defaults.d/50-vmware-k8s.toml
Outdated
Show resolved
Hide resolved
^ rebase on |
^ Yet another rebase on develop, no changes (yet) |
This change adds the necessary files for a VMware Kubernetes 1.20 variant.
^ Addressed all the changes necessary after rebase and addressed remaining PR comments! |
Issue number:
Closes #1451
Description of changes:
This change adds the necessary files for a VMware Kubernetes 1.20 variant.
This variant is currently able to join Kubernetes clusters on VMware given the proper user data.
Testing done:
All nodes used the following user data:
Built a
vmware-k8s-1.20
OVA and uploaded to vSphere. Booted 3 nodes using the above user-data viaguestinfo.userdata
. The nodes boot and properly join a previously provisioned CAPV cluster.vmtoolsd
is running and greenbusybox
podsudo sheltie
works as normalTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.