Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: add new udev rules for mounting CD-ROMs #1516

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Apr 22, 2021

Issue number:
Fixes #1427

Description of changes:

Author: Erikson Tung <etung@amazon.com>
Date:   Wed Apr 14 17:03:22 2021 -0700

    release: add new udev rules for mounting cdroms
    
    Adds new udev rules for activating the media-cdrom.mount unit whenever
    we detect media in the CD drive. Removes `WantedBy=` from the mount unit
    as it's no longer needed.

Testing done:
Build OVA and created VM in vSphere.

Booting the VM with a CD-Drive connected with datastore stored on a CD-ROM works as expected. The CD-ROM gets mounted correctly, early-boot-config is able to read user-data from it.:
boot-with-cdrom

If I remove the CD-ROM from the CD-drive afterwards, the media-cdrom.mount goes inactive as does dev-cdrom.device:
remove-cd-after

Next, if I boot the VM with no CD-ROM in the drive. The host comes up fine with both media-cdrom.mount and dev-cdrom.device inactive. If I insert a CD-ROM afterwards, they become active as expected and the CD-ROM is mounted successfully at /media/cdrom.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Adds new udev rules for activating the media-cdrom.mount unit whenever
we detect media in the CD drive. Removes `WantedBy=` from the mount unit
as it's no longer needed.
@etungsten etungsten requested review from bcressey and zmrow April 22, 2021 23:21
@etungsten etungsten changed the title release: add new udev-rules for mounting CD-ROMs release: add new udev rules for mounting CD-ROMs Apr 22, 2021
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Nice work!!

@etungsten etungsten merged commit 5800a60 into bottlerocket-os:develop Apr 23, 2021
@etungsten etungsten deleted the cd-pls branch April 23, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

media-cdrom.mount fails if the device exists but no media is present
4 participants