Archive old migrations #1540
Merged
Archive old migrations #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
Apr 29, 2021
webern
reviewed
Apr 29, 2021
Exactly, yes. You can see the full path in a little popup if you go to the "Files changed" tab and hover over the filename. |
etungsten
approved these changes
Apr 29, 2021
bcressey
approved these changes
Apr 30, 2021
webern
approved these changes
Apr 30, 2021
These migrations have already been built and released with Bottlerocket releases and don't need to be built again. The build system and os package currently build everything in the migrations directory, which can take a significant amount of time with unneeded migrations. Their source is still useful as a reference, and the files are small, so it's worthwhile keeping them in-tree rather than having to search git history.
tjkirch
force-pushed
the
archive-old-migrations
branch
from
2615d66 to
f5a48c5
Compare
|
^ Rebase on develop to resolve conflict. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing done:
Before, building the os package took ~245 seconds:
After, takes ~190 seconds:
The difference in
rpm -qlp bottlerocket-x86_64-migrations-0.0-0.x86_64.rpmis what you'd expect; before, it had all migration binaries back to 0.3.2:CLICK ME
After, only 1.1.0:
I did a
cargo make && cargo make repo, with Infra.toml pointing at an existing repo to update, and looked at the result. Thetargets/directory only has the new migration binaries, as you'd expect, which is fine - when you sync to update a repo you wouldn't delete existing target files. The manifest still has the full migration list, of course, since that's just taken from Release.toml literally. The targets.json metadata still includes the old migrations with the same hashes; the only difference (other than ordering) is the new images / kmod-kit I built.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.