-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: add setting for configuring kubeAPIQPS and kubeAPIBurst #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gthao313
force-pushed
the
kubelet-settings
branch
3 times, most recently
from
April 30, 2021 23:06
42d3e21
to
a245ce5
Compare
Push above fix conflicts. |
bcressey
approved these changes
May 3, 2021
etungsten
approved these changes
May 3, 2021
Push above fix conflicts |
etungsten
approved these changes
May 3, 2021
jpculp
approved these changes
May 3, 2021
pass kube-api-qps argument to kubelet
pass kube-api-burst argument to kubelet
Adds a migration for two new settings `settings.kubernetes.kube-api-qps` and `settings.kubernetes.kube-api-burst`
Push above fix conflicts again. |
webern
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1495
Description of changes:
Adds two new settings
kubernetes.kube-api-qps
andkubernetes.kube-api-burst
for configuringTesting done:
kube-api-qps
Creating large amount of pods (which needs to talk with kube-apiserver) at same time, and time how long it would take. Compare two argument values (smaller value and larger value ), the time that spends to create pods by smaller value is longer than by larger value, because small value limits the QPS of talking to kube-apiserver.
Step1:
kube-api-qps = 100
(larger value)Result:
Step2:
kube-api-qps = 1
lowest value (smaller value)Result:
Test result: The time that spends to create pods by smaller value
kube-api-qps = 1
will longer than by larger valuekube-api-qps = 100
, which means settingkubernetes.kube-api-qps
works.kube-api-burst
Creating large amount of pods (which needs to talk with kube-apiserver) at same time, and time how long it would take. Compare two argument values (smaller value and larger value ), the time that spends to create pods by smaller value is longer than by larger value, because small value limits the burst of talking to kube-apiserver.
Step1:
kube-api-burst= 100
(larger value)Result:
Step2:
event-burst = 1
lowest value (smaller value)Result:
Test result: The time that spends to create pods by smaller value
kube-api-burst = 1
will longer than by larger valuekube-api-burst = 100
, which means settingkubernetes.kube-api-burst
works.Migration test:
upgrade
Step1: Upgrade to v1.1.0
Step2: Specify new setting
kube-api-qps
andkube-api-burst
through control containerdowngrade
Step1: Check migration binary
Step2: Downgrade to previous verison
Step3: Check if
kube-api-qps
andkube-api-burst
have been removedTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.