Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: add symlink for secrets-store-csi-providers #1544

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

bcressey
Copy link
Contributor

Issue number:
Fixes #1524.

Description of changes:
Add a symlink to a path where providers can create their socket.

Testing done:
Installed the AWS provider for the secrets store CSI driver by following the usage instructions. Verified that the pod had access to the secret.

Verified that the sockets were created in the expected paths:

bash-5.0# ls -latr /etc/kubernetes/secrets-store-csi-providers
lrwxrwxrwx. 1 root root 40 Apr 30 14:13 /etc/kubernetes/secrets-store-csi-providers -> /var/lib/kubelet/providers/secrets-store

bash-5.0# ls -latr /var/lib/kubelet/providers/secrets-store/aws.sock   
srwxr-xr-x. 1 root root 0 Apr 30 14:16 /var/lib/kubelet/providers/secrets-store/aws.sock

bash-5.0# ls -latr /var/lib/kubelet/providers/secrets-store/aws.sock   
srwxr-xr-x. 1 root root 0 Apr 30 14:15 /var/lib/kubelet/plugins/csi-secrets-store/csi.sock

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This redirects to a path where providers can create their socket.

Signed-off-by: Ben Cressey <bcressey@amazon.com>
@bcressey bcressey requested review from webern and etungsten April 30, 2021 14:28
Copy link
Contributor

@arnaldo2792 arnaldo2792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcressey bcressey merged commit f68243c into bottlerocket-os:develop Apr 30, 2021
@bcressey bcressey deleted the secrets-store branch April 30, 2021 20:10
@rverma-dev
Copy link

@bcressey how can we use this particular ami which contains the fix?

@jhaynes
Copy link
Contributor

jhaynes commented May 5, 2021

@rverma-nsl We'll be releasing this in our 1.1.0 release which in the works right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some CSI drivers write to /etc/kubernetes/secrets-store-csi-providers
6 participants