Fixed a misleading typo for setting Labels/Taints #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Apr 30, 2021
etungsten
approved these changes
Apr 30, 2021
bcressey
approved these changes
Apr 30, 2021
|
(@tjkirch to merge this) |
arnaldo2792
pushed a commit
to arnaldo2792/bottlerocket
that referenced
this pull request
Feb 4, 2025
Document the need to quote most Kubernetes labels/taints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Labels and taints do not work if the keys aren't wrapped in strings. My nodes never connect to the cluster. There may be other places in this codebase where this issue exists.
Testing done:
N/A
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.