Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Update the README.md and add a QUICKSTART-VMWARE #1559

Merged
merged 3 commits into from
May 6, 2021

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented May 4, 2021

Issue number:
Closes #1412

Description of changes:

This adds a new QUICKSTART document for VMware, describing in depth how
to get started launching Bottlerocket using the VMware platform
This updates the top level README, adding additional details about
VMware variants as well as linking to the VMware QUICKSTART document.
README: Fix stylized left/right quotes to normal quotes

Testing done:
Ran through the steps in the QUICKSTART w/ @jpculp.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@zmrow
Copy link
Contributor Author

zmrow commented May 4, 2021

^ Missed a pair of quotes. :)

QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
@zmrow
Copy link
Contributor Author

zmrow commented May 4, 2021

^ Rebase and fix merge conflict

@zmrow
Copy link
Contributor Author

zmrow commented May 4, 2021

^ Addressed @jpculp 's feedback and added a commit to fix the stylized quotes in the README

The following will download and verify the root role itself:

```
curl -O "https://cache.bottlerocket.aws/root.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we rotate the root, we'll need to figure out how to keep this up to date. Probably just as a runbook step since the root rotation isn't super frequent.

Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

```
cat <<EOF > userdata.toml
[settings.kubernetes]
api-server = "${API_SERVER:-<API_SERVER>}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the default-value syntax with placeholders are valuable here. I think it's clear that we're using the values that we produced above, and that that one could paste something into this if they preferred.

README.md Outdated
@@ -352,6 +363,10 @@ The following settings are set for you automatically by [pluto](sources/api/) ba
* `memory`: in mebibytes from the max num of pods on the instance. `memory_to_reserve = max_num_pods * 11 + 255`.
* `ephemeral-storage`: defaults to `1Gi`.

For Kubernetes variants in AWS, the following settings are set for you automatically by [pluto](sources/api/).
* `settings.kubernetes.max-pods`: The maximum number of pods that can be scheduled on this node (limited by number of available IPv4 addresses)
* `settings.kubernetes.cluster-dns-ip`: The CIDR block of the primary network interface.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `settings.kubernetes.cluster-dns-ip`: The CIDR block of the primary network interface.
* `settings.kubernetes.cluster-dns-ip`: Derived from the EKS IPV4 Service CIDR or the CIDR block of the primary network interface.

@bcressey
Copy link
Contributor

bcressey commented May 5, 2021

I've got a fair number of comments coming as I work through this - mostly that the examples aren't super easy to copy/paste and run, which is important when there are this many manual steps.

QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
QUICKSTART-VMWARE.md Outdated Show resolved Hide resolved
Comment on lines +10 to +13
You must be able to access vSphere, via webUI or some type of client.
We will use the CLI tool [`govc`](https://github.com/vmware/govmomi/tree/master/govc) to communicate with vSphere in this quide.
`govc` can use [environment variables or take arguments](https://github.com/vmware/govmomi/tree/master/govc#usage) to specify needed parameters.
For the purposes of this guide we will assume that the following environment variables are set to the proper values in your environment:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also expect jq to be installed to work through the examples, and the AWS CLI to work through the optional steps to enable the control container.

@zmrow
Copy link
Contributor Author

zmrow commented May 5, 2021

^ Addressed all the comments! Thanks for the feedback.

@bcressey bcressey self-requested a review May 5, 2021 22:26

You'll need to install [`tuftool`](https://github.com/awslabs/tough/blob/develop/tuftool/README.md) to assist you with fetching the signed Bottlerocket OVA from the Bottlerocket TUF repository.

If you'd (optionally) like to make use of the control container, you'll need an AWS account, AWS CLI, and `jq` installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also use jq to populate the network in the spec.

zmrow added 3 commits May 6, 2021 14:45
This adds a new QUICKSTART document for VMware, describing in depth how
to get started launching Bottlerocket using the VMware platform.
This updates the top level README, adding additional details about
VMware variants as well as linking to the VMware QUICKSTART document.
@zmrow
Copy link
Contributor Author

zmrow commented May 6, 2021

^ Added the jq prerequisite.

@zmrow zmrow merged commit 7729d3c into bottlerocket-os:develop May 6, 2021
@zmrow zmrow deleted the vmw-qs branch May 6, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write VMWare variant documentation
5 participants