webpki-roots-shim: document version #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
approved these changes
May 6, 2021
etungsten
approved these changes
May 6, 2021
bcressey
approved these changes
May 7, 2021
sources/webpki-roots-shim/Cargo.toml
Outdated
| # This version number is important because it determines whether or not our shim gets used by the | ||
| # patch statement in the sources workspace's Cargo.toml. | ||
| # | ||
| # At the time of this writing, reqwest is the only crate in sources/Cargo.lock that depeneds on |
There was a problem hiding this comment.
nit
Suggested change
| # At the time of this writing, reqwest is the only crate in sources/Cargo.lock that depeneds on | |
| # At the time of this writing, reqwest is the only crate in sources/Cargo.lock that depends on |
We need to be careful with the version number in webpki-roots-shim's Cargo.toml file. This commit attempts to explain why in comments.
Apparently depeneds is in my spelling dictionary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #1539
Description of changes:
We need to be careful with the version number in webpki-roots-shim's
Cargo.toml file. This commit attempts to explain why in comments.
Testing done:
N/A
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.