-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: add setting for configuring systemReserved #1606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
Jun 8, 2021
pass system-reserved argument to kubelet
adds a migration for a new settings `settings.kubernetes.system-reserved`
gthao313
force-pushed
the
kubelet-settings
branch
from
June 8, 2021 00:45
8cf9e64
to
8e1314a
Compare
Push above update README |
etungsten
approved these changes
Jun 8, 2021
webern
approved these changes
Jun 8, 2021
tjkirch
reviewed
Jun 8, 2021
bcressey
approved these changes
Jun 9, 2021
jpculp
approved these changes
Jun 9, 2021
zmrow
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Part of #1447
Description of changes:
Adds a new settings kubernetes.system-reserved for configuring
Testing done:
launching instance with the AMI which contains new setting and check if the resources (cpu, memory, storage) have been reserved.
Step1: Check if configuration is here.
Step2: go to EKS check if the resources (cpu, memory, storage) have been reserved
NodeAllocatable = NodeCapacity - Kube-reserved - system-reserved - eviction-threshold
cpu
[settings.kubernetes.system-reserved.cpu]
cpu = "40m,"
Allocatable cpu = 4000m (NodeCapacity) - 80m (kube-reserved) -40m ( system-reserved)
EKS
memory
[settings.kubernetes.system-reserved.memory]
memory = "1000Mi"
Allocatable memory = 16089632Ki (NodeCapacity) - 893Mi (kube-reserved) -1000Mi ( system-reserved)
EKS
ephemeral-storage
[settings.kubernetes.system-reserved.ephemeral-storage]
ephemeral-storage = "1Gi"
Allocatable ephemeral-storage = 20624592Ki (NodeCapacity) - 1Gi (kube-reserved) -1Gi ( system-reserved)
Test cases
the case where the new settings are unset
Step1: Check if configuration is here.
result
systemReserved has not been configured in kubelet.
Step2: go to EKS check if the resources (cpu, memory, storage) have been reserved
cpu
Allocatable cpu(3920m) = 4000m (NodeCapacity) - 80m (kube-reserved) - 0 ( system-reserved)
memory
Allocatable memory(14900768Ki) = 15917600Ki (NodeCapacity) - 893Mi/914432Ki (kube-reserved) -0 ( system-reserved) - 100Mi/102400Ki (eviction-hard)
ephemeral-storage
Allocatable ephemeral-storage(17933882132) = 20624592Ki/21119582208 (NodeCapacity) -1Gi/1,073,741,824 (kube-reserved) -0 ( system-reserved) - 10%/2111958220.8 (eviction-hard)
Migration test:
upgrade
Step1: Upgrade to v1.1.2
Step2: Specify new setting
system-reserved
through control containerdowngrade
Step1: Check migration binary
Step2: Downgrade to previous verison
Step3: Check if
system-reserved
have been removedTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.