Store build artifacts per architecture #1630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Note because it originally confused me: we don't need to change anything about the RPM builds or the Rust/cargo used inside package builds, because the cache mount used in package builds is already arch-specific.
Testing done:
There's a relatively high blast radius for relatively few lines of code, so let me know if you can think of other tests to run.
build/state/
; here's an example of a marker for a package and for a variant artifact.build/state
; x86 state isn't touched. Example ARM markers:The (top-level) cargo fingerprint/cache is separated correctly; example package:
(Before, it was like that, but minus the $arch level.)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.