sources: update actix and tokio packages #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update actix and tokio minor versions
webern
approved these changes
Jul 14, 2021
bcressey
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Attempts to address #1650
Description of changes:
Looked through the change logs, the fix from the version bump that seems relevant is tokio-rs/tokio#3898, which addresses tokio-rs/tokio#3879.
Testing done:
Node joins cluster. I was able to set and change Bottlerocket settings fine via apiclient.
I tried reproducing the problem described by #1650 by launching 1000 instances and rebooting them all. None of the instances failed to start up. But I wasn't able to reproduce the issue even before this fix so it's unclear if it actually fixes the issue.
Please lemme know if there's anything else I should test.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.