packages: fix permissions for /var/lib/systemd/random-seed #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Jul 15, 2021
| @@ -2,3 +2,4 @@ d /run/cache 0755 root root - | |||
| d /run/lock 0755 root root - | |||
| L /var/lock - - - - /run/lock | |||
| Z /var/lib/systemd 0755 root root - | |||
| z /var/lib/systemd/random-seed 600 root root - | |||
There was a problem hiding this comment.
We should also label this secret_t by adding an entry to packages/selinux-policy/fs.cil.
This commit changes the permissions on `/var/lib/systemd/random-seed` from `755` to `600`, and SELinux label from `state_t` to `secret_t`, so that only the root user can read from the file. Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
arnaldo2792
force-pushed
the
fix-random-seed
branch
from
0925758 to
1176e7d
Compare
|
Forced push includes updates in the SELinux policy |
samuelkarp
approved these changes
Jul 16, 2021
bcressey
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N / A
Description of changes:
This commit changes the permissions on
/var/lib/systemd/random-seedfrom755to600, and SELinux label fromstate_ttosecret_t, so that only the root user can read from the file.Testing done:
# previous permissions bash-5.0# ls -lZ /var/lib/systemd drwxr-xr-x. 2 root root system_u:object_r:state_t:s0 4096 Jul 14 21:22 catalog drwxr-xr-x. 2 root root system_u:object_r:state_t:s0 4096 Jul 14 21:22 coredump drwxr-xr-x. 2 root root system_u:object_r:state_t:s0 4096 Jul 14 21:22 pstore -rwxr-xr-x. 1 root root system_u:object_r:state_t:s0 512 Jul 14 21:22 random-seed# new permissions bash-5.0# ls -lZ /var/lib/systemd/ total 20 drwxr-xr-x. 2 root root system_u:object_r:state_t:s0 4096 Jul 16 03:27 catalog drwxr-xr-x. 2 root root system_u:object_r:state_t:s0 4096 Jul 16 03:27 coredump drwxr-xr-x. 2 root root system_u:object_r:state_t:s0 4096 Jul 16 03:27 pstore -rw-------. 1 root root system_u:object_r:secret_t:s0 512 Jul 16 03:27 random-seedTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.