Revert der-parser update and lock to working version #1687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
After the merges of #1654 and #1683, we would get errors on startup from certdog saying there were invalid certificates and boot would fail. I must have done insufficient re-testing after rebasing #1683.
I bisected and found that der-parser is specifically the crate update that causes the failure. As mentioned in the comment below:
@arnaldo2792 offered to dive deeper on exactly which change in 5.1.1 is breaking, and communicate upstream or fix our code as necessary. For now, locking this version fixes our issue.
Testing done:
This resolves the certificate error on startup, and the node is otherwise healthy as well.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.