Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert der-parser update and lock to working version #1687

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Aug 2, 2021

Description of changes:

After the merges of #1654 and #1683, we would get errors on startup from certdog saying there were invalid certificates and boot would fail. I must have done insufficient re-testing after rebasing #1683.

I bisected and found that der-parser is specifically the crate update that causes the failure. As mentioned in the comment below:

# x509-parser depends on der-parser ^5.0.  5.1.1 contains breaking changes.
# The 5.1.1 release isn't in the master branch; those changes are instead in a
# 6.0.0 release, more clearly implying breaking changes.  Lock to 5.1.0.

@arnaldo2792 offered to dive deeper on exactly which change in 5.1.1 is breaking, and communicate upstream or fix our code as necessary. For now, locking this version fixes our issue.

Testing done:

This resolves the certificate error on startup, and the node is otherwise healthy as well.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@tjkirch tjkirch added this to the v1.2.0 milestone Aug 2, 2021
@tjkirch tjkirch requested review from bcressey and arnaldo2792 August 2, 2021 22:52
Copy link
Contributor

@arnaldo2792 arnaldo2792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👢

@tjkirch tjkirch mentioned this pull request Aug 2, 2021
@tjkirch tjkirch merged commit 1d0328c into bottlerocket-os:develop Aug 3, 2021
@tjkirch tjkirch deleted the certs branch August 3, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants