-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to SDK 0.23.0 #1779
Merged
Merged
update to SDK 0.23.0 #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
reviewed
Oct 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo HACK
Should we use this PR to update the GitHub workflows to use Rust 1.55 to match SDK? |
Rust 1.56 is out! 🎉 https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html |
webern
approved these changes
Oct 21, 2021
rebase with no changes |
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Path dependencies without a specified version will be treated as a wildcard dependency and cause an error, so add the version to each. Block multiple versions of crates, but skip the existing cases. The goal is to prevent new instances from coming in unnoticed. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Fix new wildcard dependencies, and update to Rust 1.56.0 for the actions workflow. |
tjkirch
approved these changes
Oct 27, 2021
etungsten
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Uses the SDK with changes from bottlerocket-os/bottlerocket-sdk#60. Notably, this includes newer versions of Rust, Go, and
cargo-deny
.Testing done:
Confirmed that new
cargo deny
checks pass with no warnings.Built
aws-k8s-1.21
variants for x86_64 and aarch64; confirmed that asonobuoy
run passes with no issues.Built
aws-ecs-1
variant for x86_64 and verified that tasks ran OK.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.