Add hotdog OCI hooks #1871
Merged
Add hotdog OCI hooks #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Dec 16, 2021
bcressey
reviewed
Dec 16, 2021
samuelkarp
reviewed
Dec 17, 2021
arnaldo2792
force-pushed
the
add-hotdog
branch
from
9a4e95a to
816ab5d
Compare
|
Forced push includes:
|
samuelkarp
approved these changes
Dec 17, 2021
webern
approved these changes
Dec 17, 2021
bcressey
reviewed
Dec 17, 2021
packages/hotdog/Cargo.toml
Outdated
Comment on lines
11
to
13
| [[package.metadata.build-package.external-files]] | ||
| url = "https://github.com/bottlerocket-os/hotdog/archive/c212cfb564850b48aa6008563074a329cee041a1/hotdog-c212cfb.tar.gz" | ||
| sha512 = "68bbd4c4fda72065eae995fe75f0f8d0a30228476051906da4bce3f66352138356bb4dd4fd8e0aa6f5822388f9c7dc04e85fa35038e91be294e4fdd4a6e970bc" |
There was a problem hiding this comment.
We want bottlerocket-os/hotdog@f300fb78 for the verbosity fix.
packages/hotdog/hotdog.spec
Outdated
| # The oci hooks commands can be compiled as we usually compile golang packages | ||
| %cross_go_configure %{goimport} | ||
| for cmd in hotdog-cc-hook hotdog-poststart-hook; do | ||
| GO111MODULE=off go build -buildmode=pie -ldflags "-linkmode=external" -o $cmd ./cmd/$cmd |
There was a problem hiding this comment.
This probably needs to change for the newer SDK:
Suggested change
| GO111MODULE=off go build -buildmode=pie -ldflags "-linkmode=external" -o $cmd ./cmd/$cmd | |
| GO111MODULE=off go build -buildmode=pie -ldflags "${GOLDFLAGS}" -o $cmd ./cmd/$cmd |
hotdog provides oci hooks to apply the hotpatch for Apache log4j2, to containers running JVM machines Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
arnaldo2792
force-pushed
the
add-hotdog
branch
from
816ab5d to
7f5c805
Compare
|
Forced push includes:
|
samuelkarp
approved these changes
Dec 17, 2021
bcressey
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N / A
Description of changes:
hotdogprovides oci hooks to apply the hotpatch for Apache log4j2, to containers running JVM machinesRemaining tasks:
Testing done:
I built it with my local copy of the sources.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.