Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub: Add "console" to terminal_output command for BIOS systems #1894

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented Jan 6, 2022

Description of changes:
This change adds the local console to the list of terminals to which grub will send output for systems using BIOS.

Before this change, on real hardware I wasn't able to see grub via serial console or local console. This change fixes that!

Testing done:
For the testing below, I bumped up the grub timeout to 10 seconds and verified grub's output:

  • EC2 virtualized x86_64 (BIOS)
  • EC2 metal x86_64 (BIOS)
  • VMware x86_64 (BIOS)
  • Supermicro SYS-E200-8D (BIOS) :)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This change adds the local console to the list of terminals to which
grub will send output.
@zmrow zmrow requested review from bcressey and cbgbt January 6, 2022 23:42
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@zmrow zmrow merged commit 5b1821a into bottlerocket-os:develop Jan 7, 2022
@zmrow zmrow deleted the grub-terminal-output branch January 7, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants