variants: Add metal-k8s-1.21 variant #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Jan 19, 2022
bcressey
reviewed
Jan 19, 2022
Comment on lines
+15
to
+17
| [package.metadata.build-variant] | ||
| image-format = "raw" |
There was a problem hiding this comment.
Let's also expand the OS image size to 4 GiB (two banks of 2 GiB) - since I expect to need some extra space for firmware, etc.
webern
approved these changes
Jan 19, 2022
sources/logdog/conf/metal-k8s.conf
Outdated
| @@ -0,0 +1 @@ | |||
| exec kube-status systemctl status kube* -l --no-pager | |||
There was a problem hiding this comment.
Is this different from the other k8s variants? (edit: the underlying question is I was wondering if there's a shared file or if we should make one)
There was a problem hiding this comment.
The aws file differs, but we could probably unify the vmware and metal files since they're the same, and both are "off-AWS" variants.
This change adds an additional variant `metal-k8s-1.21`, which includes necessary Kubernetes packages and settings for running Bottlerocket on metal in a Kubernetes cluster.
VMware and metal variants both use host containers pulled from public ECR. This change creates a single file that both variants can use.
VMware and metal variants use the same logdog config, so this change renames the config to `k8s.conf` and fixes up the symlinks accordingly.
zmrow
force-pushed
the
metal-k8s-variant
branch
from
8e1de16 to
f1ea496
Compare
|
^ Added 2 additional commits: the first unifies the public host containers into one file in models, the second unifies the "off-AWS" config into a single file in logdog. |
etungsten
approved these changes
Jan 19, 2022
bcressey
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Following along the series of changes in the
metal-devPR (#1895), this PR adds a variant meant for running Bottlerocket as a worker node in Kubernetes clusters on bare metal. It is similar in scope to the other Kubernetes variants, and includes sane defaults for running off AWS.Testing done:
Similar to #1895 , all testing was performed on 2 Supermicro SYS-E200-8D machines. Testing was performed using the following configurations:
Tests:
Ran kubelet in standalone mode and confirmed it was able to run a redis pod via static pods. (I don't currently have a Kubernetes cluster at home to join)
All host containers worked swimmingly given the correct user data
Bootstrap containers are happy
Inspected journal logs, nothing alarming there (though kubelet would really like a CNI plugin :) )
Successfully built and ran the vmware-k8s-1.21 variant to ensure I didn't break anything there. :)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.
T license.