Patch bug affecting IPv6 clusters in Kubernetes 1.21 #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Jan 24, 2022
webern
approved these changes
Jan 24, 2022
|
I approved, but the patch isn't there? Did we already have it checked in to our repo? |
The aws cloud provider was not sanitizing the imds node ip before being sent to kubelet. As a result, the address provided to the node-ip in kubelet and the one received from cloud provider mismatched.
etungsten
approved these changes
Jan 24, 2022
jpculp
approved these changes
Jan 24, 2022
I made a mistake with git while renaming files and removed the patch, but I have since rectified. My mistake! |
anguslees
reviewed
Jan 27, 2022
| nodeIPTypes := make(map[v1.NodeAddressType]bool) | ||
| for _, nodeAddress := range cloudNodeAddresses { | ||
| - if nodeAddress.Address == nodeIP.String() { | ||
| + if string(net.ParseIP(nodeAddress.Address)) == string(net.ParseIP(nodeIP.String())) { |
There was a problem hiding this comment.
This is incorrect and compares internal net.IP representations, which only compare equal 'sometimes'.
We want: if net.ParseIP(nodeAddress.Address).Equal(nodeIP) {
There was a problem hiding this comment.
Thanks for the heads up, @anguslees! We've opened an issue (#1930) and are looking into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This applies a patch for the issue described in this Kubernetes issue..
Testing done:
[ ] ensure the reproducer in the reported issue does not result in nodes without the full ipv6 octet.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.