-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap-containers/README.md #1959
Conversation
`VAR_DIR` (undeclared) => `HOST_VAR_DIR`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!!
🫕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README.md
is generated from the crate's doc comments at the top of main.rs
here:
bottlerocket/sources/api/bootstrap-containers/src/main.rs
Lines 42 to 44 in 6e5850c
HOST_VAR_DIR=/.bottlerocket/rootfs/var | |
# The directory that'll be created by this bootstrap container | |
MY_HOST_DIR=$VAR_DIR/lib/my_directory |
The fix should go there as well. If you have cargo installed, you can regenerate the README by running cargo check
to invoke the build.rs
script.
Thanks! LGTM provided the change suggested by @etungsten is addressed 👍 |
@etungsten I changed comment of bottlerocket/sources/api/bootstrap-containers/src/main.rs Not README.md Thanks |
Hi @dangen-effy , the change would need to happen for both |
@etungsten It was my mistake! Now i edited both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
VAR_DIR
(undeclared) =>HOST_VAR_DIR
Issue number:
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.