Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUICKSTART-VMWARE: fix 'tuftool download' instruction #1994

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

etungsten
Copy link
Contributor

Issue number:
N/A

Description of changes:

    QUICKSTART-VMWARE: fix 'tuftool download'
    
    There was a breaking change in tuftool v0.7.0 where the output directory
    must not exist when calling 'tuftool download'. This fixes the quickstart
    instructions for downloading an OVA.

Testing done:
I ran the commands in the quickstart with the latest tuftool version (v0.7.1):

$ tuftool download "${OUTDIR}" --target-name "${OVA}" \
>    --root ./root.json \
>    --metadata-url "https://updates.bottlerocket.aws/2020-07-07/${VARIANT}/x86_64/" \
>    --targets-url "https://updates.bottlerocket.aws/targets/"
Downloading targets to "vmware-k8s-1.21-v1.6.1"
        -> bottlerocket-vmware-k8s-1.21-x86_64-v1.6.1.ova

$ govc import.spec "${OUTDIR}/${OVA}" > bottlerocket_spec.json

$ cat bottlerocket_spec.json
{
  "DiskProvisioning": "flat",
  "IPAllocationPolicy": "dhcpPolicy",
  "IPProtocol": "IPv4",
  "NetworkMapping": [
    {
      "Name": "VM Network",
      "Network": ""
    }
  ],
  "MarkAsTemplate": false,
  "PowerOn": false,
  "InjectOvfEnv": false,
  "WaitForIP": false,
  "Name": null
}

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

There was a breaking change in tuftool v0.7.0 where the output directory
must not exist when calling 'tuftool download'. This fixes the quickstart
instructions for downloading an OVA.
@etungsten etungsten requested a review from zmrow March 12, 2022 19:21
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏞️

@etungsten etungsten merged commit caa3a5c into bottlerocket-os:develop Mar 15, 2022
@etungsten etungsten deleted the vmware-quickstart-fix branch March 15, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants