Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ap-southeast-3: Jakarta #2080

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Conversation

jpculp
Copy link
Member

@jpculp jpculp commented Apr 19, 2022

Issue number:

#1899 (won't be done until we perform a release and update the docs accordingly)

Description of changes:

This commit adds support for ap-southeast-3 by adding the ECR account IDs to schnauzer, while also patching rusoto crates with rusoto/rusoto@37bac10.

This also switches the repository of the pause container, while staying more or less on the same version.

Testing done:

Build, publish, and launch...

  • aws-ecs-1
  • aws-k8s-1.21

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jpculp jpculp changed the title Add ECR account IDs for ap-southeast-3: Jakarta Add support for ap-southeast-3: Jakarta Apr 20, 2022
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rusoto fixes look good.

Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpculp
Copy link
Member Author

jpculp commented Apr 22, 2022

  • Patched all the rusoto crates.
  • Update pause container to 3.6.

@jpculp
Copy link
Member Author

jpculp commented Apr 22, 2022

  • Rather than update to pause container 3.6, we'll just use 3.1-eksbuild.1 instead.

@jpculp jpculp requested a review from bcressey April 22, 2022 00:27
@jpculp jpculp marked this pull request as ready for review April 22, 2022 00:31
@jpculp jpculp merged commit d0aac83 into bottlerocket-os:develop Apr 22, 2022
@jpculp jpculp deleted the jakarta branch April 22, 2022 00:59
@jpculp jpculp mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants