add CAP_NET_ADMIN to bootstrap containers #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`iptables` needs CAP_NET_ADMIN along with the default capabilities granted to containers. This allows bootstrap containers to use `iptables` to configure the packet filter rules and policies, e.g. to drop incoming connections by default. Signed-off-by: Ben Cressey <bcressey@amazon.com>
etungsten
approved these changes
Jul 5, 2022
arnaldo2792
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
iptablesneeds CAP_NET_ADMIN along with the default capabilities granted to containers.This allows bootstrap containers to use
iptablesto configure the packet filter rules and policies, e.g. to drop incoming connections by default.Testing done:
Ran a bootstrap container with
iptablescommands. Without this change, the commands failed with a "Permission denied (you must be root)" error. With this change, the commands ran successfully.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.