packages: add keyutils #2907
Merged
packages: add keyutils #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
approved these changes
Mar 18, 2023
bcressey
reviewed
Mar 18, 2023
keyutils is a mechanism used by the kernel to reach into userspace. Typically this is used to fetch security keys, but it is also a mechanism that the kernel uses to resolve domain names.
|
Force pushed to address feedback from @bcressey |
bcressey
approved these changes
Mar 18, 2023
| %make_build \\\ | ||
| NO_ARLIB=1 \\\ | ||
| ETCDIR=%{_cross_sysconfdir} \\\ | ||
| LIBDIR=%{_cross_libdir} \\\ |
There was a problem hiding this comment.
nit: it's very unlikely that this will ever matter, but setting PREFIX will put the right paths in libkeyutils.pc (which we don't and probably won't use):
Suggested change
| LIBDIR=%{_cross_libdir} \\\ | |
| PREFIX=%{_cross_prefix} \\\ | |
| LIBDIR=%{_cross_libdir} \\\ |
There was a problem hiding this comment.
I added the PREFIX here and compared libkeyutils.pc before and after the change, but it seems like the paths are already correct?
Before:
libdir=/x86_64-bottlerocket-linux-gnu/sys-root/usr/lib
includedir=/x86_64-bottlerocket-linux-gnu/sys-root/usr/include
Name: libkeyutils
Description: keyutils library
Version: 1.6.1
Cflags: -I${includedir}
Libs: -L${libdir} -lkeyutils
After:
libdir=/x86_64-bottlerocket-linux-gnu/sys-root/usr/lib
includedir=/x86_64-bottlerocket-linux-gnu/sys-root/usr/include
Name: libkeyutils
Description: keyutils library
Version: 1.6.1
Cflags: -I${includedir}
Libs: -L${libdir} -lkeyutils
arnaldo2792
approved these changes
Mar 20, 2023
zmrow
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
n/a
Description of changes:
This change is required when mounting some distributed filesystems. The Linux kernel needs the ability to resolve domain names. To do this, it uses an "upcall" procedure to interact with dns resolution in userspace. That "upcall" procedure uses the Linux userspace keyring system -- specifically
/sbin/request-key.Of note:
I've removed keyring configuration options from
/etc/request-key.confother than the DNS resolver. Our userspace utilities don't need them, and we haven't otherwise fielded requests about the missing utilities for the kernel.Testing done:
/etc/request-key.confare correctdns_resolverTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.