Update linter, fix new warnings. #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
approved these changes
Apr 10, 2024
Update setup-go from v3 to v5, and golangci-lint-action from v3 to v4. Update .golangci.yaml for the new version of golangci-lint, and fix the three unused-parameter lints it finds in host-ctr.
|
Yes, we should bump |
jpculp
approved these changes
Apr 10, 2024
bcressey
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update golangci-lint-action from v3 to v4, update .golangci.yaml for the new version of golangci-lint, and fix the three unused-parameter lints it finds in host-ctr.
Dependabot opened a PR for the upgrade from v3 to v4 on February 12 (#3773). This failed CI because the new lint failed host-ctr.
Testing done:
Manual golangci-lint on the directories currently in our golangci-lint workflow. This pull request should trigger an automatic run of that workflow, which should pass if my manual testing reproduced its steps correctly.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.