apiclient: revert set/apply client error messages #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Jun 5, 2024
webern
approved these changes
Jun 5, 2024
arnaldo2792
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #4021
Description of changes:
@bcressey noticed that on system reboot on a Bottlerocket instance, the system failed to reboot due to a settings-committer error. This was because for default transactions (bottlerocket-launch), the changes need to be ignored by settings-committer via a Response Status from the APIServer. But, we had updated the Error response in #3987 to make our Client side messaging match what was present before. This change caused the dependents (in this case settings-committer) to change its behavior.
The fix here is to revert the client side messaging, so that consumers of the APIClient library will continue to work as is. We will have another PR focused on improving the Client side messaging to match what was there previously.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.