Mount static kmod as /usr/local/sbin/modprobe #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaldo2792
reviewed
Jun 6, 2024
yeazelm
reviewed
Jun 6, 2024
| @@ -102,6 +102,15 @@ oci-defaults = { version = "v1", helpers = ["oci_defaults"] } | |||
| "mode=755", | |||
| "size=65536k" | |||
| ] | |||
| }, | |||
| { | |||
| "destination": "/usr/local/sbin/modprobe", | |||
There was a problem hiding this comment.
Have we confirmed this will be used instead of the provided modprobe for containers that include it? Do we know where this path related in the default PATH for these containers?
There was a problem hiding this comment.
The linked script in the description printed the default PATH in the container images. For all of them /usr/local/sbin is the first path in the list.
There was a problem hiding this comment.
Yup! Along with that, I also validated loading and unloading a kernel module on all the container images + cilium in that script and did not see any unexpected failures.
|
Added |
bcressey
approved these changes
Jun 6, 2024
|
arnaldo2792
approved these changes
Jun 6, 2024
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Updates #3968
Description of changes:
This change mounts the static kmod built in #3981 into a customer container.
This time, the mount target is
/usr/local/sbin/modprobeTesting done:
I ran the script here to generate the kubernetes podspec to validate modprobe on 23 containers including:
No errors on any of them.
No errors running internal testing for ECS either
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.