Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #4055
Closes #4055
Description of changes:
This change adds the
socat
package to theaws-dev
variant to be used by our downstream customers. Specifically, it includes the following:socat.spec
which is similar to the previous spec file we had forsocat
with some changes to account for new features added to the updated version1.8.0.0
Cargo.toml
for the new package0001-xioopts-conditionally-compile-applyopts_termios_valu.patch
needed to successfully compile the newsocat
version. Prior to this patch, we got a compilation error for an undefined reference toxiotermios_value
, which was defined in a conditionally compiled code block that we want disabled. To fix this, in the patch we add that same conditional compilation directiveWITH_TERMIOS
to the functionapplyopts_termios_value
which was using that undefined reference.socat
as a dependency toaws-dev
which includes updates to itsCargo.toml
and the general variantCargo.lock
Testing done:
aws-dev
variant successfully builds and launches.socat
binary exists and runs successfully. We testedsocat
by using it to connect a TCP port to a UNIX socket and verifying we can use the port to get responses.Further testing for the downstream use case also looks good.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.