-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to core kit #4060
Migrate to core kit #4060
Commits on Jun 17, 2024
-
packages: remove unnecessary packages
They are now provided by the Bottlerocket Core Kit Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for ab4a79e - Browse repository at this point
Copy the full SHA ab4a79eView commit details
Commits on Jun 18, 2024
-
sources: remove unnecessary sources
They were migrated to the Bottlerocket Core Kit Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 3ccc2ac - Browse repository at this point
Copy the full SHA 3ccc2acView commit details -
variants: add settings-plugins and settings-extensions as build depen…
…dencies All the packages the variants depend on are already built in the Bottlerocket Core Kit Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for f9a4e5d - Browse repository at this point
Copy the full SHA f9a4e5dView commit details -
workspace: migrate to Cargo.toml
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 8b64586 - Browse repository at this point
Copy the full SHA 8b64586View commit details -
It was migrated to the Bottlerocket core kit Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for f062d50 - Browse repository at this point
Copy the full SHA f062d50View commit details -
add settings-migrations package
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for f489a8a - Browse repository at this point
Copy the full SHA f489a8aView commit details -
migrations: relocate to settings-migrations
Migrations need to stay in-tree along with plugins and defaults, because they are directly related to how settings are configured and how they evolve from one release to the next. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 70de521 - Browse repository at this point
Copy the full SHA 70de521View commit details
Commits on Jun 19, 2024
-
Makefile: update for compatibility with Bottlerocket Core Kit
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for cf2c8b3 - Browse repository at this point
Copy the full SHA cf2c8b3View commit details -
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 363309d - Browse repository at this point
Copy the full SHA 363309dView commit details -
settings-plugins: do not prefer shared linking
The SDK is built for two host architectures - x86_64 and aarch64. Each build includes the same two target architectures. However, the libstd.so binary for a given target architecture will not be the same across the two host SDK images, because they are built on different systems and at different times. To reduce file sizes, we prefer dynamically linking to libstd for all Rust binaries, and arrange to install libstd through the libstd-rust package. Prior to the kit migration, we always built the final image with the same host SDK image that was used to build all packages, so the question of which libstd should be shipped never came up. In the kits world, we need the libstd-rust that corresponds to the many Rust binaries that come from the core kit. However, if we prefer dynamic linking, then we also need the libstd-rust that matches the Rust binaries built locally, which may not be the same if the kit was built on a different host architecture. Sidestep this for now by not preferring shared linking for settings plugins, so that they are statically linked to the libstd present in the build environment, and do not require it to be installed in the final image. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 7f02f74 - Browse repository at this point
Copy the full SHA 7f02f74View commit details -
github: adapt github actions for migration to core kit
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 0bf673a - Browse repository at this point
Copy the full SHA 0bf673aView commit details -
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 5e340b2 - Browse repository at this point
Copy the full SHA 5e340b2View commit details