-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 builds for host-containers #694
Conversation
The build finished and the statically built
|
6c24f90
to
c69bae1
Compare
Rebased on the latest changes to the Ignore the fixups and such for the time being - they're there for my own benefit if folks have feedback that affect any of them. I'll rebase to squash them down before merging! 👍 |
51451a3
to
4795927
Compare
LGTM. Do you want to add the second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎐
@bcressey we'll do CI integration as a follow up, getting ARM builds isn't yet prioritized work (at the moment). We'll include handling |
Issue #, if available:
#468
Description of changes:
container.mk
has been added to consolidate the shared bits ofhost-container
container image builds and also to support thearm64
builds.The logic within
container.mk
supports both native builds on each platform (eg:amd64
,arm64
) but also allows for adding stubs to permit building all architectures with binfmt stubs supporting the other arches. N.B: I've providedbinfmt
as a convenience for development, we'll likely use automated builds on each target platform.A single call to make will build the
thar-control
container images foramd64
andarm64
:Marked as Draft as I'm waiting on the bash build to wrap upWaiting to drop this in on a host and see it do the things!The containers work!
See also: #689
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.