Remove cruft not required in new releases #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Feb 24, 2020
tjkirch
force-pushed
the
mycruft-holmes
branch
from
019b12a to
61f631d
Compare
|
This push changes "settings.example" to "settings.motd" per discussion with bcressey above. #774 (comment) Updating testing in the description now. |
It's useful to have an example setting so that users can see it in documentation and follow along, learning the API by actually making calls, without worrying about breaking their system. We were using hostname and timezone for this, but those sounded like real settings (and were originally intended to be real settings) so it was confusing. motd is a "real" setting in that it updates /etc/motd, but that's very low risk and only exposed to the user in any case. Plus, with low risk, it's fun to see an actual impact on your system.
tjkirch
force-pushed
the
mycruft-holmes
branch
from
61f631d to
6069812
Compare
|
This push just fixes a typo in the updated commit message; sorry! |
This will be a breaking release, so we clear the migrations list.
|
This push adds a commit that updates Release.toml, removing the migrations that were removed in this PR, and updating the version to reflect why. |
bcressey
approved these changes
Feb 26, 2020
|
🕵🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done:
Updated unit tests pass.
I launched an instance and was able to run a pod OK. The migrations tarball is produced, but empty, as expected.
I saw the new default motd in /etc/motd. I changed the setting, committed, and saw the change in /etc/motd.
Regarding the removal of the migrator interface workaround, I tested the new interface didn't need it in #644, and the old interface doesn't exist anymore with this PR.