-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new update URIs #778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bcressey
reviewed
Feb 26, 2020
bcressey
approved these changes
Feb 26, 2020
iliana
approved these changes
Feb 26, 2020
zmrow
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍀
tjkirch
force-pushed
the
updates-uris
branch
from
February 26, 2020 17:14
9a7eb14
to
04320d6
Compare
This push changes the date to 2020-02-02 per discussion above :P |
I disagree with the date change but am not going to block on it. :) 🚢 |
tjkirch
force-pushed
the
updates-uris
branch
from
February 26, 2020 17:52
04320d6
to
e996f9a
Compare
This push rebases on changes from #777. |
iliana
approved these changes
Feb 26, 2020
tjkirch
force-pushed
the
updates-uris
branch
from
February 26, 2020 18:28
e996f9a
to
c3d8925
Compare
Just a rebase on develop to fix the conflict with the motd setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This uses the new OS information made available in #777 to switch us to our new updates URIs that include variant and arch.
Testing done:
Basic tests done with #777.
The new URI values show up: