Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new update URIs #778

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Switch to new update URIs #778

merged 1 commit into from
Feb 26, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Feb 25, 2020

Description of changes:

This uses the new OS information made available in #777 to switch us to our new updates URIs that include variant and arch.

Testing done:

Basic tests done with #777.

The new URI values show up:

  "updates": {
    "metadata-base-url": "https://updates.bottlerocket.aws/2020-02-20/aws-k8s/x86_64/",
    "target-base-url": "https://updates.bottlerocket.aws/targets/",

@tjkirch tjkirch requested a review from iliana February 25, 2020 23:24
@tjkirch tjkirch mentioned this pull request Feb 25, 2020
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍀

@tjkirch
Copy link
Contributor Author

tjkirch commented Feb 26, 2020

This push changes the date to 2020-02-02 per discussion above :P

@iliana
Copy link
Contributor

iliana commented Feb 26, 2020

I disagree with the date change but am not going to block on it. :)

🚢

@tjkirch
Copy link
Contributor Author

tjkirch commented Feb 26, 2020

This push rebases on changes from #777.

@tjkirch tjkirch changed the base branch from os-api to develop February 26, 2020 18:26
@tjkirch
Copy link
Contributor Author

tjkirch commented Feb 26, 2020

Just a rebase on develop to fix the conflict with the motd setting.

@tjkirch tjkirch merged commit 802c996 into develop Feb 26, 2020
@tjkirch tjkirch deleted the updates-uris branch February 26, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants