amiize: more carefully clean up resources before retries #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Feb 28, 2020
samuelkarp
approved these changes
Feb 28, 2020
webern
approved these changes
Feb 28, 2020
This adds a cleanup step before each point where we retry the amiization from scratch. It also adds cleanup of the root and data snapshot on failure, since most of the time this wouldn't be used and would sit forever.
tjkirch
force-pushed
the
amiize-cleanup
branch
from
c05a7a6 to
0a1e0b2
Compare
|
This push removes comments that no longer apply regarding resource cleanup problems. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cleanup step before each point where we retry the amiization from
scratch. It also adds cleanup of the root and data snapshot on failure, since
most of the time this wouldn't be used and would sit forever.
Fixes #755.
Testing done:
I ran it fully to see it succeed, then started inserting
falsecommands beforecheck_returncalls to check the retry and cleanup behavior. I tried for a couple different single continue statements, and a couple differentcontinue 2for the loops. In each case it did the cleanup and retries correctly.