Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment unused licenses in whitelist so we don't get warnings #827

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Mar 6, 2020

Testing done:

Before, we'd always see this:

warning: license was not encountered

    ┌── /home/ANT.AMAZON.COM/tjk/work/thar/sources/deny.toml:22:5 ───
    │
 22 │     "Zlib",
    │     ^^^^^^ no crate used this license
    │

warning: license was not encountered

    ┌── /home/ANT.AMAZON.COM/tjk/work/thar/tools/buildsys/deny.toml:14:5 ───
    │
 14 │     "BSD-2-Clause",
    │     ^^^^^^^^^^^^^^ no crate used this license
    │

warning: license was not encountered

    ┌── /home/ANT.AMAZON.COM/tjk/work/thar/tools/buildsys/deny.toml:21:5 ───
    │
 21 │     "Zlib",
    │     ^^^^^^ no crate used this license
    │

After, no warnings.

@tjkirch tjkirch requested a review from iliana March 6, 2020 17:37
@tjkirch tjkirch merged commit cc32aeb into develop Mar 6, 2020
@tjkirch tjkirch deleted the unused-licenses branch March 6, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants