documentation: persistent volume csi plugin #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
This is good, but I wonder if it'd be even better to move the CNI step into the "cluster creation" block to clarify that it's mandatory, and to rename "Remaining cluster configuration" to "Optional cluster configuration" to clarify that this new bit and conntrack aren't required. As we get more steps in our quickstart, I think it's important to emphasize the ones that are actually needed by all users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #885
Description of changes:
Briefly note in the documentation that the EBS CSI Plugin driver is needed to create persistent volumes and link to more information. We've seen a couple of people tripped up by this, and I think this will help.
Testing done:
None, but I had previously followed the linked-to instructions with success.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.