-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrator: end-to-end test #956
Conversation
Re-organize using
Rebase. Still need to fix an oops in Cargo.toml |
Fix an oops in |
Fix another oops (actually remove the test from |
Organizes the test in the way that @tjkirch recommend (once I finally understood!) Also uses the new version of pentacle and uses a script instead of calling out to rustc
Deletes a stray file. I still need to go through comments from #930 and try to transfer any of them over to here. |
Forgot a thing in Cargo.toml |
Gawd, sorry for the flailage. This one should actually have the changes that include pentacle and uses a bash script. I have too many branches on too many machines! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming your remaining checks.
Fixes a couple of @tjkirch comments. |
Fix a comment. |
Moves |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please confirm in the testing section that you ran an instance and checked the data store that storewolf creates? (And normal behavior we test...)
Restore Option in storewolf function. |
rebase develop |
Change a comment. |
Issue number:
Related to #91 #905 #930
Description of changes
Move most everything to
src/run.rs
and add a filesrc/run_tests.rs
which contains a migrator end-to-end test.Testing done:
Ran the unit tests. Also ran a Bottlerocket instance and did an upgrade/downgrade test with test migrations.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.